generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nats-server runs as non-root #319
Merged
kyma-bot
merged 17 commits into
kyma-project:main
from
friedrichwilken:remove-root-user-from-nats-server
Feb 21, 2024
Merged
Changes from 15 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c9ca63e
add debug messages to github action
friedrichwilken 66d25c2
Run as non-root user
friedrichwilken 6f91b14
Extend attempts
friedrichwilken eb5125f
Extend attempts
friedrichwilken d42bc5f
Change owner of storage via init container
friedrichwilken fa9b529
Change owner of jetstream storage
friedrichwilken cdb7f7d
Give root permissions to init container
friedrichwilken 744140e
Change groups of owners
friedrichwilken 282a5dd
Change only the JetStream storage
friedrichwilken 1d879bd
Change usergroup to fsgroup
friedrichwilken 219a060
Revert "extend attempts"
friedrichwilken 063977b
Revert "extend attempts"
friedrichwilken 096a541
Use alpine instead of busybox
friedrichwilken 6128137
also change rights for files
friedrichwilken bc1af44
Add 'done' log message
friedrichwilken 7071123
Revert "add debug messages to github action"
friedrichwilken 6ac85ad
Rename initContainer
friedrichwilken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,6 +94,15 @@ spec: | |
# reload to the server without restarting the pod. | ||
shareProcessNamespace: true | ||
|
||
initContainers: | ||
- name: fix-jetstream-storage | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
securityContext: | ||
runAsUser: 0 | ||
image: alpine:latest | ||
command: ["sh", "-c", "chown -R 1000:10001 {{ .Values.nats.jetstream.fileStorage.storageDirectory }} && chmod -R 755 {{ .Values.nats.jetstream.fileStorage.storageDirectory }} && echo 'Done!'"] | ||
volumeMounts: | ||
- name: {{ include "nats.fullname" . }}-js-pvc | ||
mountPath: {{ .Values.nats.jetstream.fileStorage.storageDirectory }} | ||
################# | ||
# # | ||
# NATS Server # | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? can we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the changes.