Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Simplify retry functions #335

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Feb 20, 2024

Description

Staticcheck does not like the Retry functions we use in the e2e tests, so let's improve them:

  • Simplify the Retry and RetryGet functions.

Tests

Issues with changes would be caught via the e2e tests.

Related
kyma-project/eventing-manager#503

@friedrichwilken friedrichwilken requested a review from a team as a code owner February 20, 2024 19:24
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2024
@friedrichwilken friedrichwilken changed the title Simplify retry function Chore: Simplify retry functions Feb 21, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 21, 2024
@kyma-bot kyma-bot merged commit d68926c into kyma-project:main Feb 21, 2024
6 checks passed
@friedrichwilken friedrichwilken deleted the simplify-retry branch February 21, 2024 07:36
@friedrichwilken friedrichwilken restored the simplify-retry branch February 21, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants