Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Linter configuration - Importas #340

Merged
merged 41 commits into from
Feb 22, 2024
Merged

chore: Linter configuration - Importas #340

merged 41 commits into from
Feb 22, 2024

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Feb 22, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Importas for NATS-Manager
  • This version still uses local linter config

Related issue(s)

Check the importas related commits here: https://github.com/kyma-project/nats-manager/pull/340/commits

Kiss, Tibor added 30 commits February 20, 2024 10:01
Makefile
965628e
loggercheck
ff412e1
importas: metav1
7271277
kcorev1 "k8s.io/api/core/v1"
55a632d
kutilruntime "k8s.io/apimachinery/pkg/util/runtime"
c498d51
kscheme "k8s.io/client-go/kubernetes/scheme"
e386199
kappsv1 "k8s.io/api/apps/v1"
b9b60c7
kcontrollerruntime "sigs.k8s.io/controller-runtime"
3345085
k8s.io/api/apps/v1
4207741
ktypes "k8s.io/apimachinery/pkg/types"
cae475c
kapierrors "k8s.io/apimachinery/pkg/api/errors"
a5f42e7
klogzap "sigs.k8s.io/controller-runtime/pkg/log/zap"
4a70cc7
nmkmocks "github.com/kyma-project/nats-manager/pkg/k8s/mocks"
8d66861
kapiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
7d1b5d2
onsigomegatypes "github.com/onsi/gomega/types"
c06fe0f
kapiextclientset "k8s.io/apiextensions-apiserver/pkg/client/clientset…
8cd1a55 
…/clientset"
nmcontroller "github.com/kyma-project/nats-manager/internal/controlle…
0307e06 
…r/nats"
nmapiv1alpha1 "github.com/kyma-project/nats-manager/api/v1alpha1"
843ae0a
kapipolicyv1 "k8s.io/api/policy/v1"
34520ec
nmkchartmocks "github.com/kyma-project/nats-manager/pkg/k8s/chart/mocks"
65bcc9b
kapiextclientsetfake "k8s.io/apiextensions-apiserver/pkg/client/clien…
3c7fe5d 
…tset/clientset/fake"
kutilyaml "k8s.io/apimachinery/pkg/util/yaml"
3a5032b
nmmanagermocks "github.com/kyma-project/nats-manager/pkg/manager/mocks"
24cf819
nmctrlmocks "github.com/kyma-project/nats-manager/internal/controller…
58ba690 
…/nats/mocks"
nmctrl
6cc21d7
nmmgr "github.com/kyma-project/nats-manager/pkg/manager"
b9889b8
nmmgrmocks
69f9c82
nmctrlurl "github.com/kyma-project/nats-manager/internal/controller/n…
46c1ca1 
…ats/url"
nmmgrmocks
da3c502
nmtsmatchers "github.com/kyma-project/nats-manager/testutils/matchers…
aec914a 
…/nats"
@the1bit the1bit added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/ci Issues or PRs related to CI related topics kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 22, 2024
@the1bit the1bit requested review from a team as code owners February 22, 2024 10:23
@the1bit the1bit requested a review from mfaizanse February 22, 2024 10:23
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2024
@the1bit the1bit changed the title Linter configuration: Importas chore: Linter configuration - Importas Feb 22, 2024
@the1bit the1bit removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 22, 2024
muralov
muralov reviewed Feb 22, 2024
View reviewed changes
.gitignore
Comment on lines +47 to +48
.golangci.yaml
.golangci.yaml_old
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.golangci.yaml
.golangci.yaml_old
.golangci.*

@kyma-bot kyma-bot merged commit aa46b5b into kyma-project:main Feb 22, 2024
6 checks passed
@the1bit the1bit deleted the Centralized-Linter branch February 22, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov approved these changes

@NHingerl NHingerl NHingerl approved these changes

@mfaizanse mfaizanse Awaiting requested review from mfaizanse mfaizanse is a code owner automatically assigned from kyma-project/eventing

@marcobebway marcobebway Awaiting requested review from marcobebway

Assignees

@muralov muralov

@NHingerl NHingerl

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the1bit @muralov @NHingerl @kyma-bot