Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: linters and central linter configuraton #344

Merged
merged 12 commits into from
Mar 1, 2024
Merged

chore: linters and central linter configuraton #344

merged 12 commits into from
Mar 1, 2024

Conversation

the1bit
Copy link
Contributor

@the1bit the1bit commented Feb 28, 2024

Description

Changes proposed in this pull request:

  • Central Linter Config
  • Linters:
    • bodyclose
    • gci
    • funlen
    • gomoddirectives
    • dupword
    • thelper
    • tagalign
    • perfsprint

Related issue(s)

@the1bit the1bit requested a review from a team as a code owner February 28, 2024 16:11
@the1bit the1bit requested a review from muralov February 28, 2024 16:11
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@the1bit the1bit added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2024
@the1bit the1bit removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024
friedrichwilken
friedrichwilken requested changes Mar 1, 2024
View reviewed changes
.github/workflows/codequality.yml Outdated Show resolved Hide resolved
@the1bit the1bit requested a review from friedrichwilken March 1, 2024 11:09
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 1, 2024
@kyma-bot kyma-bot merged commit 84519d3 into kyma-project:main Mar 1, 2024
7 checks passed
@the1bit the1bit deleted the Linter-drop-3 branch March 1, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@muralov muralov Awaiting requested review from muralov muralov is a code owner automatically assigned from kyma-project/eventing

@mfaizanse mfaizanse Awaiting requested review from mfaizanse

@marcobebway marcobebway Awaiting requested review from marcobebway

@grischperl grischperl Awaiting requested review from grischperl

Assignees

@friedrichwilken friedrichwilken

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the1bit @friedrichwilken @kyma-bot