Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable nats istio mtls #437

Closed
wants to merge 4 commits into from
Closed

feat: enable nats istio mtls #437

wants to merge 4 commits into from

Conversation

muralov
Copy link
Contributor

@muralov muralov commented Sep 26, 2024

Description

Enable Istio mTLS for NATS cluster

Changes proposed in this pull request:

  • Enable sidecar injection for NATS cluster pods
  • Enable Istio mTLS with destination rule

Related issue(s)
#435

@muralov muralov requested a review from a team as a code owner September 26, 2024 14:48
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 26, 2024
@muralov muralov changed the title Enable nats istio mtls feature: enable nats istio mtls Sep 26, 2024
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2024
@muralov muralov changed the title feature: enable nats istio mtls feat: enable nats istio mtls Sep 26, 2024
@muralov muralov force-pushed the enable-nats-istio-mtls branch 2 times, most recently from d2da8f8 to bafcdfd Compare September 26, 2024 15:59
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2024
@muralov muralov force-pushed the enable-nats-istio-mtls branch 2 times, most recently from f7c9f2b to c74ac62 Compare September 26, 2024 16:29
@muralov muralov force-pushed the enable-nats-istio-mtls branch 4 times, most recently from 6722b22 to 81d1492 Compare September 27, 2024 05:05
@muralov
Add rbac rule for PeerAuthentication
9d31039 
PeerAuthentication enforces mTLS for NATS pods
@muralov muralov force-pushed the enable-nats-istio-mtls branch from 81d1492 to 9d31039 Compare September 27, 2024 05:23
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
@muralov muralov linked an issue Sep 28, 2024 that may be closed by this pull request
POC: Enable Istio sidecar injection in NATS Pods #435
Closed
@muralov muralov removed the request for review from friedrichwilken September 30, 2024 08:13
@muralov muralov marked this pull request as draft September 30, 2024 08:13
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@muralov muralov mentioned this pull request Sep 30, 2024
Closed
@muralov muralov reopened this Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

This pull request has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This pull request has been automatically closed due to the lack of recent activity.
/lifecycle rotten

@github-actions github-actions bot closed this Dec 9, 2024
@kyma-bot kyma-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POC: Enable Istio sidecar injection in NATS Pods
3 participants
@muralov @marcobebway @kyma-bot