Add serverless build (push) #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKalke
requested review from
pPrecel,
dbadura,
kwiatekus,
Cortey,
anoipm and
halamix2
as code owners
kyma-bot
added
cla: yes
pPrecel
reviewed
Jul 11, 2024
Comment on lines
+10
to
+12
| permissions: | ||
| id-token: write | ||
| contents: read |
There was a problem hiding this comment.
I would suggest to keep comments about permissions (source)
There was a problem hiding this comment.
I will add it in next PR, thanks
|
Why you've decided to add three building jobs only? I see in another PR that there are many more of them. |
Oh, I see. It's already merged... It's ok but now I have another suggestion. Maybe should we split builds between three files? push, pull_request, and release? I think there is no reason to keep for example three builds in a separate file because we will not edit them and definitely do not remove/add images so often. |
pPrecel
previously approved these changes
Jul 12, 2024
pPrecel
added
the
do-not-merge/hold
pPrecel
removed
the
do-not-merge/hold
pPrecel
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#1033