Hana client contract test hardening #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwiatekus
requested review from
pPrecel,
dbadura,
Cortey,
anoipm,
MichalKalke and
halamix2
as code owners
kyma-bot
added
cla: yes
kwiatekus
added
the
kind/failing-test
pPrecel
reviewed
Jul 19, 2024
| // it is expected to leave here | ||
| return err; | ||
| // it is expected to leave here. The purpose is to check if hana client returns a known error instead of crashing the whole container with SIGSEGV | ||
| if(err.sqlState && err.sqlState.startsWith("HY")){ |
There was a problem hiding this comment.
why the HY prefix? I would suggest leaving here comment with details or even linking the hana client documentation
pPrecel
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#330