Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding any annotation to functions spec annotations #1346

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Support adding any annotation to functions spec annotations #1346

merged 2 commits into from
Dec 27, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Dec 27, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • support adding any annotation to functions spec annotations

Related issue(s)

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2024
@pPrecel pPrecel changed the title fix deploy annotations Support adding any annotation to functions spec annotations Dec 27, 2024
@pPrecel pPrecel added kind/bug Categorizes issue or PR as related to a bug. area/serverless Issues or PRs related to serverless labels Dec 27, 2024
@pPrecel pPrecel marked this pull request as ready for review December 27, 2024 10:02
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 27, 2024
@anoipm anoipm self-assigned this Dec 27, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 27, 2024
@pPrecel pPrecel merged commit 77a643e into kyma-project:main Dec 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

@halamix2 halamix2 Awaiting requested review from halamix2 halamix2 is a code owner

Assignees

@anoipm anoipm

Labels
area/serverless Issues or PRs related to serverless cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pPrecel @anoipm @kyma-bot