Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Serverless CR details view #1367

Merged

Conversation

kwiatekus
Copy link
Contributor

Description

Changes proposed in this pull request:

  • use details.status panel to show reconciliation conditions
  • render configuration from status only. (desired spec is defined in the form view)

Related issue(s)
#1236

Screenshot 2025-01-08 at 18 54 16

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@pPrecel pPrecel assigned anoipm and unassigned pPrecel Jan 9, 2025
anoipm
anoipm previously approved these changes Jan 9, 2025
@kyma-bot kyma-bot added lgtm Looks good to me! and removed lgtm Looks good to me! labels Jan 9, 2025
@kwiatekus kwiatekus force-pushed the reconfigure-serverless-cr-details-view branch from 01e3c03 to 958c2d4 Compare January 9, 2025 12:33
anoipm
anoipm previously approved these changes Jan 9, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 9, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 9, 2025
@kwiatekus kwiatekus enabled auto-merge (squash) January 9, 2025 13:42
@kwiatekus kwiatekus merged commit f25920b into kyma-project:main Jan 9, 2025
21 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 9, 2025
kwiatekus added a commit to kwiatekus/serverless-manager that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants