Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node22 image building and testing #1368

Merged
merged 4 commits into from
Jan 9, 2025
Merged

fix: node22 image building and testing #1368

merged 4 commits into from
Jan 9, 2025

Conversation

halamix2
Copy link
Member

@halamix2 halamix2 commented Jan 9, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • bump Node22 version to fix image build
  • also made integration tests required in the repo settings
    • they were not starting with image build failing

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2025
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2025
@halamix2 halamix2 enabled auto-merge (squash) January 9, 2025 09:27
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 9, 2025
@halamix2 halamix2 merged commit 25048d0 into kyma-project:main Jan 9, 2025
39 checks passed
@halamix2 halamix2 deleted the node22-fix branch January 9, 2025 09:42
kwiatekus pushed a commit to kwiatekus/serverless-manager that referenced this pull request Jan 9, 2025
@halamix2 @kwiatekus
fix: node22 image building and testing (kyma-project#1368)
155946e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoipm anoipm anoipm approved these changes

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@anoipm anoipm

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @anoipm @kyma-bot