Improve makefiles #845
Merged
Improve makefiles #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger,
nataliasitko,
pPrecel,
kwiatekus,
Cortey,
anoipm and
MichalKalke
as code owners
kyma-bot
added
cla: yes
dbadura
force-pushed
the
improve-makefiles
branch
from
5b347e6 to
acefd0e
Compare
kyma-bot
added
size/M
anoipm
reviewed
Apr 4, 2024
| @@ -9,7 +9,7 @@ Pros of the architecture: | |||
| * extensibility | |||
|
|
|||
| ## Dependencies description | |||
| * `Makefile` - The main makefile that allows for installing and running the Serverless Operator. It's a high-level target to run the module without knowing its internals. It's the first contact point for the Serverless module users. | |||
| * `Makefile` - The main makefile that allows for installing and running the Serverless. It's a high-level target to run the module without knowing its internals. It's the first contact point for the Serverless module users. | |||
There was a problem hiding this comment.
Why you remove Operator? IMO main makefile run Serverless Operator.
There was a problem hiding this comment.
I want to stress it that this makefile works with serverless. Sure under the hood it's installed by operator, but this is the implementation detail.
pPrecel
reviewed
Apr 4, 2024
anoipm
reviewed
Apr 4, 2024
anoipm
added
the
do-not-merge/hold
kyma-bot
added
size/L
anoipm
previously approved these changes
Apr 8, 2024
anoipm
removed
the
do-not-merge/hold
grego952
reviewed
Apr 8, 2024
Co-authored-by: Grzegorz Karaluch <[email protected]>
grego952
approved these changes
Apr 10, 2024
anoipm
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)