Add real local target #928
Conversation
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
dbadura
requested review from
pPrecel,
kwiatekus,
Cortey,
anoipm,
MichalKalke and
halamix2
as code owners
kyma-bot
added
cla: yes
|
|
||
| ##@ K3D | ||
|
|
||
| .PHONY: create-k3d | ||
| create-k3d: kyma ## Create k3d with kyma CRDs. | ||
| ${KYMA} provision k3d --registry-port ${REGISTRY_PORT} --name ${CLUSTER_NAME} --ci -p 6080:8080@loadbalancer -p 6433:8433@loadbalancer | ||
| create-k3d: delete-k3d ## Delete old k3d registry and cluster. Create preconfigured k3d with registry |
There was a problem hiding this comment.
The kyma cli used to delete old k3d and registry, As I used plain k3d cli I added delete-k3d as dependency to create-k3d target
dbadura
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger and
nataliasitko
as code owners
README.md
Outdated
| ``` | ||
|
|
||
| You have to add `127.0.0.1 k3d-kyma-registry.locahost` to your `etc/hosts`. | ||
| More details: https://k3d.io/v5.3.0/usage/registries/#preface-referencing-local-registries |
There was a problem hiding this comment.
I would suggest trying to push built image to the localhost:5000 registry and then pull it from the k3d-kyma-registry.localhost:5000 (from inside the cluster). I think in this case there is no need to push image to the k3d-kyma-registry.localhost:5000 and path hosts
| echo "==== Local Changes ====" | ||
| yq '.global.images' ${VALUES_FILE} | ||
| yq '.global.images' "${VALUES_FILE}" | ||
| yq '.global.containerRegistry' "${VALUES_FILE}" |
There was a problem hiding this comment.
I would suggest to install yq in bin if it doesn't exist. We don't need to generate another requirement for every developer/user
|
/retest pre-serverless-runtimes-nodejs-v18-build |
|
@halamix2: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pre-serverless-runtimes-nodejs-v18-build |
Co-authored-by: Natalia Sitko <[email protected]>
Description
Changes proposed in this pull request:
Related issue(s)
#826