Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fn tag calculation #929

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Improve fn tag calculation #929

merged 7 commits into from
Apr 29, 2024

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Apr 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add baseRuntimageImage to the reconciler config
  • calculate function image tag based on baseRuntimeImage

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
@pPrecel pPrecel marked this pull request as ready for review April 25, 2024 21:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@halamix2
Copy link
Member

/retest pre-serverless-runtimes-nodejs-v18-build
/retest pre-serverless-runtimes-nodejs-v20-build
/retest pre-serverless-runtimes-python312-build
/retest pre-serverless-runtimes-python39-build

@kyma-bot
Copy link
Contributor

@halamix2: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pre-serverless-controller-build
  • /test pre-serverless-jobinit-build
  • /test pre-serverless-operator-build
  • /test pre-serverless-runtimes-java17-jvm-alpha-build
  • /test pre-serverless-runtimes-nodejs-v18-build
  • /test pre-serverless-runtimes-python312-build
  • /test pre-serverless-runtimes-python39-build
  • /test pre-serverless-webhook-build

The following commands are available to trigger optional jobs:

  • /test pre-gitserver-build
  • /test pre-serverless-runtimes-nodejs-v20-build

Use /test all to run the following jobs that were automatically triggered:

  • pre-serverless-controller-build
  • pre-serverless-jobinit-build
  • pre-serverless-operator-build
  • pre-serverless-runtimes-java17-jvm-alpha-build
  • pre-serverless-runtimes-nodejs-v18-build
  • pre-serverless-runtimes-nodejs-v20-build
  • pre-serverless-runtimes-python312-build
  • pre-serverless-runtimes-python39-build
  • pre-serverless-webhook-build

In response to this:

/retest pre-serverless-runtimes-nodejs-v18-build
/retest pre-serverless-runtimes-nodejs-v20-build
/retest pre-serverless-runtimes-python312-build
/retest pre-serverless-runtimes-python39-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halamix2
Copy link
Member

/test pre-serverless-runtimes-nodejs-v18-build
/test pre-serverless-runtimes-nodejs-v20-build
/test pre-serverless-runtimes-python312-build
/test pre-serverless-runtimes-python39-build

@pPrecel
Copy link
Contributor Author

pPrecel commented Apr 29, 2024

@dbadura suggests refactoring the status.runtimeImage usage. Everything is described in this ticket

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 29, 2024
@kyma-bot kyma-bot merged commit f16934e into kyma-project:main Apr 29, 2024
23 checks passed
pPrecel added a commit to pPrecel/serverless-manager that referenced this pull request Apr 30, 2024
@pPrecel
Improve fn tag calculation (kyma-project#929)
a346e62
@pPrecel pPrecel mentioned this pull request Apr 30, 2024
Merged
kyma-bot pushed a commit that referenced this pull request Apr 30, 2024
@pPrecel
Cherry-Pick: Improve fn tag calculation (#929) (#948)
1cbe9d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura left review comments

@anoipm anoipm anoipm approved these changes

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

@halamix2 halamix2 Awaiting requested review from halamix2 halamix2 is a code owner

Assignees

@anoipm anoipm

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pPrecel @kyma-bot @halamix2 @anoipm @dbadura