Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lint to separate file #955

Merged
merged 1 commit into from
May 7, 2024
Merged

Move lint to separate file #955

merged 1 commit into from
May 7, 2024

Conversation

MichalKalke
Copy link
Contributor

@MichalKalke MichalKalke commented May 6, 2024 •
edited
Loading

Description
Move lint to separate file

Issue
#961

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented May 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2024
@MichalKalke MichalKalke force-pushed the improve-operator-verify branch 2 times, most recently from f2e7245 to da0c3b5 Compare May 7, 2024 13:09
@MichalKalke MichalKalke force-pushed the improve-operator-verify branch from 9193910 to b963f2c Compare May 7, 2024 13:15
@MichalKalke MichalKalke changed the title Move lint to seperate file, move setup go to another acition Move lint to seperate file May 7, 2024
@MichalKalke MichalKalke changed the title Move lint to seperate file Move lint to separate file May 7, 2024
@MichalKalke MichalKalke added the kind/feature Categorizes issue or PR as related to a new feature. label May 7, 2024
@MichalKalke MichalKalke marked this pull request as ready for review May 7, 2024 13:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
dbadura
dbadura reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to run all linters on any change to operator or serverless?

@dbadura dbadura self-assigned this May 7, 2024
@anoipm
Copy link
Contributor

anoipm commented May 7, 2024

Do we want to run all linters on any change to operator or serverless?

Maybe not but current solution is much better than previous when we run linters after any changes except docs.

@kyma-bot kyma-bot added the lgtm Looks good to me! label May 7, 2024
@kyma-bot kyma-bot merged commit 809eba1 into kyma-project:main May 7, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura approved these changes

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@halamix2 halamix2 Awaiting requested review from halamix2 halamix2 is a code owner

Assignees

@dbadura dbadura

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalKalke @kyma-bot @anoipm @dbadura