Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC verifier docs #11024

Merged
merged 12 commits into from
Jun 24, 2024
Merged

OIDC verifier docs #11024

merged 12 commits into from
Jun 24, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Jun 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added documentation for oidc-token-verifier tool.
  • Added activity diagram for oidc-token-verifier tool.
  • Added more detailed code comments in oidc-token-verifier tool.
  • Added missing function documentation in oidc package.

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2024
@dekiel dekiel marked this pull request as ready for review June 14, 2024 16:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 14, 2024
@dekiel dekiel requested a review from akiioto June 19, 2024 22:20
akiioto
akiioto previously approved these changes Jun 20, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 20, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2024
@dekiel dekiel requested a review from akiioto June 24, 2024 09:36
@dekiel
Copy link
Contributor Author

dekiel commented Jun 24, 2024

Replaced diagrams with .svg files.

IwonaLanger
IwonaLanger reviewed Jun 24, 2024
View reviewed changes
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
cmd/oidc-token-verifier/README.md Outdated Show resolved Hide resolved
@dekiel dekiel requested a review from IwonaLanger June 24, 2024 10:41
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 24, 2024
@kyma-bot kyma-bot merged commit fbeadfd into kyma-project:main Jun 24, 2024
12 checks passed
@dekiel dekiel deleted the oidc-verifier-docs branch June 24, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@akiioto akiioto akiioto approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj mmitoraj is a code owner

@NHingerl NHingerl Awaiting requested review from NHingerl NHingerl is a code owner

@grego952 grego952 Awaiting requested review from grego952 grego952 is a code owner

@nataliasitko nataliasitko Awaiting requested review from nataliasitko nataliasitko is a code owner

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@KacperMalachowski KacperMalachowski Awaiting requested review from KacperMalachowski KacperMalachowski is a code owner automatically assigned from kyma-project/prow

@TorstenD-SAP TorstenD-SAP Awaiting requested review from TorstenD-SAP TorstenD-SAP is a code owner automatically assigned from kyma-project/prow

Assignees

@akiioto akiioto

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. image-builder lgtm Looks good to me! oidc-token-verifier size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dekiel @kyma-bot @akiioto @IwonaLanger