Verify oidc token against extended expiration time #12218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added function for checking extended expiration time
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
Configure extended expiration time through flag
kyma-bot
added
size/L
akiioto
force-pushed
the
extended-expiration
branch
from
de2d75f to
ccdef29
Compare
revert to Token align with Token
akiioto
force-pushed
the
extended-expiration
branch
from
ccdef29 to
556739f
Compare
Check if expiration timestamp is in the future Test VerifyExtendedExpiration method
dekiel
changed the title
kyma-bot
removed
the
do-not-merge/work-in-progress
akiioto
approved these changes
Oct 25, 2024
|
/cla |
|
Successfully reached out to cla-assistant.io to initialize recheck of PR #12218 |
KacperMalachowski
pushed a commit
to KacperMalachowski/test-infra
that referenced
this pull request
Nov 6, 2024
* Allow 10 minutes of grace period before the token expire * test * Split token and claims verification Added function for checking extended expiration time * Use extended expiration when standard expiration was to short * Mask raw token in debug logs Configure extended expiration time through flag * Align with the code structure and test update revert to Token align with Token * Accept ClaimsReader interface in ValidateClaims instead a concrete type Check if expiration timestamp is in the future Test VerifyExtendedExpiration method * cleanup TokenProcessor tests --------- Co-authored-by: Patryk Dobrowolski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to long queued time of ADO pipelines GitHub oidc tokens passed from Image builder GitHub Actions are expiring. This causes failed image builds. To prevent failed builds when high load on ADO is observed oidc token verifier will verify oidc tokens with extended expiration time.
Example error in failed ADO run: https://dev.azure.com/hyperspace-pipelines/kyma/_build/results?buildId=7329713&view=logs&j=3eaab1e8-b99d-54c2-e3b9-c8d721213979&t=94b89c64-0a6c-5eb1-9ee6-a00128da7d80&l=33
Changes proposed in this pull request: