Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling merge group event #12400

Merged
merged 8 commits into from
Nov 25, 2024
Merged

Fix handling merge group event #12400

merged 8 commits into from
Nov 25, 2024

Conversation

KacperMalachowski
Copy link
Contributor

@KacperMalachowski KacperMalachowski commented Nov 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Change event payload to one originate from test-infra repository
  • Update test to match new event payload
  • Set isPullRequest to true for merge group to allow passing the pull head sha.

Related issue(s)

See: #12116

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Nov 25, 2024
@KacperMalachowski KacperMalachowski marked this pull request as draft November 25, 2024 09:33
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. no-changes and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Nov 25, 2024 •
edited
Loading

Plan Result

CI link

No changes. Your infrastructure matches the configuration.

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 25, 2024
@KacperMalachowski KacperMalachowski changed the title Fix merge group ib Fix handling merge group event Nov 25, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review November 25, 2024 09:57
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 25, 2024
@kyma-bot kyma-bot merged commit 505e160 into kyma-project:main Nov 25, 2024
13 checks passed
@KacperMalachowski KacperMalachowski deleted the fix-merge-group-ib branch November 25, 2024 12:58
@Sawthis Sawthis assigned KacperMalachowski and unassigned Sawthis Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sawthis Sawthis Sawthis approved these changes

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@akiioto akiioto Awaiting requested review from akiioto akiioto is a code owner automatically assigned from kyma-project/prow

Assignees

@KacperMalachowski KacperMalachowski

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! no-changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KacperMalachowski @kyma-bot @Sawthis