Set authorization always when oidc token is provided #12577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
KacperMalachowski
requested review from
neighbors-dev-bot and
a team
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
kyma-bot
added
cla: yes
Sawthis
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently OIDC token is set in authorizaiton parameter only for Github Actions, we need to set it always to avoid confusions.
The fix implementation was due to some security concerns about leaking the token, but now it's causing confusions. To avoid that let's move repsonsibility for token on user.
Changes proposed in this pull request: