Warden promotion workflow #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwiatekus
requested review from
dbadura,
anoipm,
pPrecel,
Cortey and
MichalKalke
as code owners
kyma-bot
added
cla: yes
kwiatekus
added
do-not-merge/work-in-progress
kyma-bot
added
the
size/L
kwiatekus
removed
the
do-not-merge/work-in-progress
pPrecel
requested changes
Jan 23, 2024
|
|
||
| upgrade-images: | ||
| name: Bump warden images references | ||
| needs: verify-head-status |
There was a problem hiding this comment.
Needs a job that does not exist. Please remove it
| run: | | ||
| git config --global user.email "${BOT_EMAIL}" | ||
| git config --global user.name "${BOT_USERNAME}" | ||
| git clone "https://${BOT_USERNAME}:${GH_ENTERPRISE_TOKEN}@github.tools.sap/${BOT_USERNAME}/module-manifests.git" |
There was a problem hiding this comment.
Is the internal Github URL, not sensitive data enough to hide it in secret/env?
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
The actions/checkout@v4 action by default checkouts to the SHA in the action context that triggered the workflow. In this case, we need to checkout to new SHA created by push in the first job (upgrade-images). I would suggest to add ref: ${{ github.ref_name }} arg.
pPrecel
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: