Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using /common/logging from kyma monorepo #200

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Stop using /common/logging from kyma monorepo #200

merged 2 commits into from
Feb 26, 2024

Conversation

kwiatekus
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • use logging library locally

Related issue(s)
#198

@kwiatekus kwiatekus added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 23, 2024
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 23, 2024
@kwiatekus kwiatekus added this to the 0.13.0 milestone Feb 23, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 23, 2024
pPrecel
pPrecel reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@pPrecel pPrecel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we still have dependency to the kyma repo (to the common logging) here. Are we ok with that? I would expect after merging this PR that we should base only on internal logging configuration

@kwiatekus
Copy link
Collaborator Author

I see that we still have dependency to the kyma repo (to the common logging) here. Are we ok with that? I would expect after merging this PR that we should base only on internal logging configuration

Cleaned up. THX

@kwiatekus kwiatekus assigned pPrecel and unassigned kwiatekus Feb 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 26, 2024
@kyma-bot kyma-bot merged commit 7fda65b into kyma-project:main Feb 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

@dbadura dbadura Awaiting requested review from dbadura

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@pPrecel pPrecel

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kwiatekus @pPrecel @kyma-bot