Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't fail on broken optional credentials #364

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix: don't fail on broken optional credentials #364

merged 1 commit into from
Dec 30, 2024

Conversation

halamix2
Copy link
Member

Description

Changes proposed in this pull request:

  • don't fail on broken optional credentials
  • try to get image anonymously, then use credentials if needed

Related issue(s)

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2024
@pPrecel pPrecel self-assigned this Dec 30, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2024
@halamix2 halamix2 merged commit 5b1f3ad into kyma-project:main Dec 30, 2024
8 checks passed
@halamix2 halamix2 deleted the secrets branch December 30, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

@dbadura dbadura Awaiting requested review from dbadura

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

@MichalKalke MichalKalke Awaiting requested review from MichalKalke MichalKalke is a code owner

Assignees

@pPrecel pPrecel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halamix2 @pPrecel @kyma-bot