Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master' into rr/merge-upstream
Browse files Browse the repository at this point in the history
  • Loading branch information
reubenr0d committed May 3, 2024
2 parents 26c5446 + e9cbadb commit ff10f39
Show file tree
Hide file tree
Showing 57 changed files with 2,760 additions and 601 deletions.
File renamed without changes.
File renamed without changes.
File renamed without changes.
78 changes: 78 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report_ai_video.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: AI Bug report
description: Create a report to help us improve.
labels:
- "type: bug"
- "AI"
assignees:
- rickstaa
body:
- type: markdown
attributes:
value: |
## Bug report
Please fill out the following information to help us understand your issue.
> [!IMPORTANT]
> This repository is only related to the core bugs with the AI branch of the go-livepeer software (i.e. `ai-video`). It does not cover bugs related to running AI pipelines and AI models used on the AI subnet. For these issues, please refer to the [AI-worker repository](https://github.com/livepeer/ai-worker/issues/new/choose)
- type: textarea
attributes:
label: Describe the bug
description: A clear and concise description of what the bug is.
validations:
required: true
- type: textarea
attributes:
label: Reproduction steps
description: "How do you trigger this bug? Please walk us through it step by step."
value: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
- type: textarea
attributes:
label: Expected behaviour
description: A clear and concise description of what you expected to happen.
- type: dropdown
id: severity
attributes:
label: Severity
description: "How severe is this bug?"
options:
- Minor
- Major
- Critical
- type: textarea
attributes:
label: Screenshots / Live demo link
description: If applicable, add screenshots to help explain your problem.
placeholder: Paste the image link as markdown image
- type: dropdown
id: os
attributes:
label: OS
description: "What operating system are you using?"
options:
- Windows
- Mac
- Linux
- type: dropdown
id: running_on
attributes:
label: Running on
description: "Where are you running the application?"
options:
- Local
- Docker
- type: input
attributes:
label: AI go-livepeer version
description: "What version of the AI-worker are you using?"
- type: input
attributes:
label: AI go-livepeer commit hash
description: "Could you please provide the commit hash of the `ai-video` branch that you are currently using?"
- type: textarea
attributes:
label: Additional context
description: Add any other context about the problem here.
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: true
contact_links:
- name: Go-livepeer Question
url: https://github.com/livepeer/go-livepeer/discussions
about: Please ask and answer questions related to the go-livepeer software here.
- name: Livepeer Question
url: https://discord.gg/livepeer
about: "Have a general Livepeer question? Join us in the Livepeer Discord server. We're here to help!"
47 changes: 47 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request_ai.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: AI Feature request
description: Suggest an idea for this project.
labels:
- "type: feature"
- "AI"
assignees:
- rickstaa
body:
- type: markdown
attributes:
value: |
## Feature Request
Please fill out the following information to help us understand your request.
> [!IMPORTANT]
> This repository is only related to feature requests related to the the AI branch of the go-livepeer software (i.e. `ai-video`). It does not cover feature requests related to the addition of new AI pipelines and AI models used on the AI subnet. For these issues, please refer to the [AI-worker repository](https://github.com/livepeer/ai-worker/issues/new/choose).
- type: textarea
attributes:
label: Is your feature request related to a problem? Please describe.
description:
A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
validations:
required: true
- type: textarea
attributes:
label: Describe the solution you'd like
description: A clear and concise description of what you want to happen.
- type: textarea
attributes:
label: Describe alternatives you've considered
description:
A clear and concise description of any alternative solutions or features
you've considered.
- type: textarea
attributes:
label: Use Case
description: "Please describe why you want this feature to be added. This will help us prioritize your request."
- type: textarea
attributes:
label: Expected Outcome
description: "What do you expect to happen once this feature is implemented?"
- type: textarea
attributes:
label: Additional context
description:
Add any other context or screenshots about the feature request here.
2 changes: 2 additions & 0 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
AI:
- base-branch: "ai-video"
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@ jobs:
- GOOS: linux
GOARCH: amd64
runner: ubuntu-20.04
container: livepeerci/cuda:11.7.1-cudnn8-devel-ubuntu20.04
container: livepeerci/cuda:12.0.0-cudnn8-devel-ubuntu20.04
type: gpu

- GOOS: linux
GOARCH: arm64
runner: ubuntu-20.04
container: livepeerci/cuda:11.7.1-cudnn8-devel-ubuntu20.04
container: livepeerci/cuda:12.0.0-cudnn8-devel-ubuntu20.04
type: gpu

- GOOS: windows
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
permissions:
packages: write
contents: read
runs-on: ubuntu-20.04
runs-on: oxford
steps:
- name: Check out code
uses: actions/[email protected]
Expand All @@ -34,7 +34,7 @@ jobs:
sudo apt purge -yqq dotnet-* mono-* llvm-* libllvm* powershell* openjdk-* \
temurin-* mongodb-* firefox mysql-* \
hhvm google-chrome-stable \
libgl1-mesa-dri microsoft-edge-stable azure-cli
libgl1-mesa-dri microsoft-edge-stable azure-cli || true
sudo apt autoremove -y
sudo rm -rf /usr/share/dotnet /usr/local/lib/android
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/issue-labeler.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Label issues
on:
issues:
types:
- reopened
- opened
types: [opened, reopened]

jobs:
label_issues:
if: ${{ github.event_name == 'issues' }}
runs-on: ubuntu-latest
permissions:
issues: write
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/pr-labeler.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: Label PRs
on:
pull_request_target:
types: [opened, reopened]

jobs:
label_pull_requests:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: actions/labeler@v5
9 changes: 5 additions & 4 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ jobs:
- name: Install protobuf
run: |
go install github.com/golang/protobuf/[email protected]
go install google.golang.org/protobuf/cmd/[email protected]
go install google.golang.org/grpc/cmd/[email protected]
sudo apt update
sudo apt install -yqq protobuf-compiler
Expand Down Expand Up @@ -91,7 +92,7 @@ jobs:
git diff --exit-code
- name: Lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v4
with:
version: v1.52.2
skip-pkg-cache: true
Expand All @@ -114,11 +115,11 @@ jobs:
./test_e2e.sh
- name: Upload coverage reports
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CI_CODECOV_TOKEN }}
files: ./cover.out
name: ${{ github.event.repository.name }}
verbose: true
gcov_ignore: ./eth/stubclient.go

codeql:
Expand Down
84 changes: 83 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,87 @@
# Changelog

## v0.7.4

### Breaking Changes 🚨🚨

### Features ⚒

#### General

- [#2989](https://github.com/livepeer/go-livepeer/pull/2989) Revert "Update ffmpeg version" (@thomshutt)

#### Broadcaster

#### Orchestrator

#### Transcoder

### Bug Fixes 🐞

#### CLI

#### General

#### Broadcaster

#### Orchestrator

#### Transcoder

## v0.7.3

### Breaking Changes 🚨🚨

### Features ⚒

#### General

- [#2978](https://github.com/livepeer/go-livepeer/pull/2978) Update CUDA version from 11.x to 12.x (@leszko)
- [#2973](https://github.com/livepeer/go-livepeer/pull/2973) Update ffmpeg version (@thomshutt)
- [#2981](https://github.com/livepeer/go-livepeer/pull/2981) Add support for prices in custom currencies like USD (@victorges)

#### Broadcaster

#### Orchestrator

#### Transcoder

### Bug Fixes 🐞

#### CLI

#### General

#### Broadcaster

#### Orchestrator

#### Transcoder

## v0.7.2

### Breaking Changes 🚨🚨

- None

#### General
- [#2938](https://github.com/livepeer/go-livepeer/pull/2938) Add `tmp` folder to `.gitignore` (@rickstaa)

#### Broadcaster
- [#2896](https://github.com/livepeer/go-livepeer/pull/2896) Use FPS of 60, rather than 120 for cost estimation (@thomshutt)
- [#2948](https://github.com/livepeer/go-livepeer/pull/2948) Remove logging from metrics methods (@thomshutt)

#### Orchestrator
- [#2911](https://github.com/livepeer/go-livepeer/pull/2911) Set default price with livepeer_cli option 20 (@eliteprox)
- [#2928](https://github.com/livepeer/go-livepeer/pull/2928) Added `startupAvailabilityCheck` param to skip the availability check on startup (@stronk-dev)
- [#2905](https://github.com/livepeer/go-livepeer/pull/2905) Add `reward_call_errors` Prometheus metric (@rickstaa)
- [#2958](https://github.com/livepeer/go-livepeer/pull/2958) Return parsing error when failing to parse B prices (@thomshutt)

#### Transcoder

### Bug Fixes 🐞
- [#2914](https://github.com/livepeer/go-livepeer/pull/2914) fixes a bug that prevented `pricePerBroadcaster` JSON files with line-breaks from being parsed correctly (@rickstaa).

## v0.7.1

### Breaking Changes 🚨🚨
Expand Down Expand Up @@ -538,7 +620,7 @@ Additional highlights of this release:
- Support for EIP-1559 (otherwise known as type 2) Ethereum transactions which results in more predictable transaction confirmation times, reduces the chance of stuck pending transactions and avoids overpaying in gas fees. If you are interested in additional details on the implications of EIP-1559 transactions refer to this [resource](https://hackmd.io/@timbeiko/1559-resources).
- An improvement in ticket parameter generation for orchestrators to prevent short lived gas price spikes on the Ethereum network from disrupting streams.
- The node will automatically detect if the GPU enters an unrecoverable state and crash. The reason for crashing upon detecting an unrecoverable GPU state is that no transcoding will
be possible in this scenario until the node is restarted. We recommend node operators to setup a process for monitoring if their node is still up and starting the node if it has crashed. For reference, a bash script similar to [this one](https://gist.github.com/jailuthra/03c3d65d0bbff457cae8f9a14b4c04b7) can be used to automate restarts of the node in the event of a crash.
be possible in this scenario until the node is restarted. We recommend node operators to setup a process for monitoring if their node is still up and starting the node if it has crashed. For reference, a bash script similar to [this one](https://gist.github.com/jailuthra/03c3d65d0bbff457cae8f9a14b4c04b7) can be used to automate restarts of the node in the event of a crash.

Thanks to everyone that submitted bug reports and assisted in testing!

Expand Down
14 changes: 4 additions & 10 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,25 @@

#### General

- #2938 Add `tmp` folder to `.gitignore` (@rickstaa)

#### Broadcaster

- #2896 Use FPS of 60, rather then 120 for cost estimation (@thomshutt)
- #2948 Remove logging from metrics methods (@thomshutt)
- [#2995](https://github.com/livepeer/go-livepeer/pull/2995) server: Allow Os price to increase up to 2x mid-session (@victorges)
- [#2999](https://github.com/livepeer/go-livepeer/pull/2999) server,discovery: Allow B to use any O in case none match maxPrice (@victorges)

#### Orchestrator

- #2911 Set default price with livepeer_cli option 20 (@eliteprox)
- #2928 Added `startupAvailabilityCheck` param to skip the availability check on startup (@stronk-dev)
- #2905 Add `reward_call_errors` Prometheus metric (@rickstaa)

#### Transcoder

### Bug Fixes 🐞

- \[#2914](https://github.com/livepeer/go-livepeer/issues/2912) fixes a bug that prevented `pricePerBroadcaster` JSON files with line-breaks from being parsed correctly (@rickstaa).

#### CLI

#### General

#### Broadcaster

- [#2994](https://github.com/livepeer/go-livepeer/pull/2994) server: Skip redundant maxPrice check in ongoing session (@victorges)

#### Orchestrator

#### Transcoder
Loading

0 comments on commit ff10f39

Please sign in to comment.