Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

バグ修正(format predictionの1d_flagのインデックス, dotsの除去が正常にできていない) #258

Open
wants to merge 10 commits into
base: stable
Choose a base branch
from

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Jan 12, 2022

標記の通り、format predictionの1d_flagのインデックスがfirst_indexでなくてsecond_indexを取っているバグとdotsの除去ができていない(くっついてしまって変数と認識されないことがある)ところを修正しました。

これによって、1d_flagが正常に動いていなかったものが動くようになり新たに50個ほどのpredictionが成功するようになりました。

一方で面白いことにこのバグによって読めてしまっていた5つほどが失敗するようになりました。原因は二次元配列が転置していて、従来のsecond_indexをとるとうまくいってしまうもの、または1次元の文字列を読む(c_0c_1...c_N)といったものです。
詳しくはtests/resources/test_fmtprediction/answer.txtをご覧ください。

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2022

Codecov Report

Merging #258 (f8f2388) into stable (acd3835) will increase coverage by 0.06%.
The diff coverage is 94.59%.

❗ Current head f8f2388 differs from pull request most recent head 1e33460. Consider uploading reports for the commit 1e33460 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           stable     #258      +/-   ##
==========================================
+ Coverage   90.52%   90.58%   +0.06%     
==========================================
  Files          64       64              
  Lines        2764     2847      +83     
==========================================
+ Hits         2502     2579      +77     
- Misses        262      268       +6     
Impacted Files Coverage Δ
atcodertools/fmtprediction/tokenize_format.py 100.00% <ø> (ø)
atcodertools/fmtprediction/predict_format.py 89.39% <89.79%> (-4.55%) ⬇️
...tcodertools/fmtprediction/predict_simple_format.py 98.21% <98.27%> (-0.23%) ⬇️
atcodertools/client/models/problem_content.py 95.45% <100.00%> (+0.10%) ⬆️
atcodertools/release_management/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants