Log errors during discovery (#132)

* feat: log errors during discovery

* chore: bump version

* fix: properly count errors

packages/discovery/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @l2beat/discovery
 
+## 0.42.0
+
+### Minor Changes
+
+- Log all the discovery errors at the end of the execution
+
 ## 0.41.0
 
 ### Minor Changes

packages/discovery/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@l2beat/discovery",
   "description": "L2Beat discovery - engine & tooling utilized for keeping an eye on L2s",
-  "version": "0.41.0",
+  "version": "0.42.0",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "bin": {

packages/discovery/src/discovery/engine/DiscoveryEngine.ts

@@ -109,14 +109,28 @@ export class DiscoveryEngine {
   }
 
   private checkErrors(resolved: Analysis[]): void {
-    let errors = 0
+    const errorMsgs = []
+    let errorCount = 0
     for (const analysis of resolved) {
-      if (analysis.type === 'Contract') {
-        errors += Object.keys(analysis.errors).length
+      if (
+        analysis.type === 'Contract' &&
+        Object.keys(analysis.errors).length > 0
+      ) {
+        const msgStart = `${analysis.name}(${analysis.address.toString()}): {`
+        const msgEnd = '\n}'
+        const errorMessages = Object.entries(analysis.errors).map(
+          ([field, error]) => `\n\t${field}: ${error}`,
+        )
+
+        errorCount += errorMessages.length
+        errorMsgs.push([msgStart, ...errorMessages, msgEnd].join(''))
       }
     }
-    if (errors > 0) {
-      this.logger.logError(`Errors during discovery: ${errors}`)
+    if (errorCount > 0) {
+      this.logger.logError(`Errors during discovery: ${errorCount}`)
+      for (const error of errorMsgs) {
+        this.logger.logError(error)
+      }
     }
   }
 }