This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implement MultiIndexer #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sz-piotr
requested review from
michalsidzej,
antooni,
maciekzygmunt and
torztomasz
|
torztomasz
reviewed
Mar 25, 2024
torztomasz
reviewed
Mar 25, 2024
torztomasz
reviewed
Mar 25, 2024
torztomasz
reviewed
Mar 25, 2024
torztomasz
reviewed
Mar 25, 2024
antooni
reviewed
Mar 25, 2024
antooni
reviewed
Mar 25, 2024
torztomasz
reviewed
Mar 25, 2024
torztomasz
approved these changes
Mar 25, 2024
antooni
approved these changes
Mar 25, 2024
adamiak
pushed a commit
to l2beat/l2beat
that referenced
this pull request
Apr 24, 2024
* Add support for undefined height * Refactor undefined to null for height * Rename update function parameters * Remove useless examples * Make indexers safer * Add stub MultiIndexer * Implement toRanges * Add tests for MultiIndexer * Fix some edge cases * Simplify configuration types * Start calling saveConfigurations * Add more tests for MultiIndexer * MultiIndexer should now be feature complete * Make the API nicer sacrificing safety * Remove old example code * Add example of a PriceIndexer * Simplify the code by only counting full hours * Do not propagate repeated ticks * Add BlockIndexer example * Add some todos * Get rid of null heights * Make from inclusive * Make everything inclusive and store all configurations * Add more tests * Add test for update heights * add more tests * add toRanges test case * Refactor updateSavedConfigurations to be a method * Add returns doc comments * Update uif version * add test for maxHeight --------- Co-authored-by: antooni <[email protected]> Co-authored-by: Tomasz Tórz <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-4539
This PR also:
fromparameter to be inclusive as opposed to exclusive (which was the previous behavior)getSaveHeighttoinitializeBaseIndexertoIndexerSliceIndexerRemaining:
Docs