Fetch multisig threshold in the proxy detector

packages/discovery-types/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @l2beat/discovery-types
 
+## 0.8.1
+
+### Patch Changes
+
+- Compute multisig threshold in the proxy detector
+
 ## 0.8.0
 
 ### Minor Changes

packages/discovery-types/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@l2beat/discovery-types",
   "description": "Common types for @l2beat/discovery.",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "license": "MIT",
   "repository": "https://github.com/l2beat/tools",
   "bugs": {

packages/discovery-types/src/proxyDetails.ts

@@ -51,6 +51,7 @@ export interface GnosisSafeUpgradeability {
   type: 'gnosis safe'
   masterCopy: EthereumAddress
   modules: EthereumAddress[]
+  threshold: string
 }
 
 export interface GnosisSafeZodiacModuleUpgradeability {

packages/discovery/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @l2beat/discovery
 
+## 0.46.6
+
+### Patch Changes
+
+- Compute multisig threshold in the proxy detector
+- Updated dependencies
+  - @l2beat/[email protected]
+
 ## 0.46.5
 
 ### Patch Changes

packages/discovery/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@l2beat/discovery",
   "description": "L2Beat discovery - engine & tooling utilized for keeping an eye on L2s",
-  "version": "0.46.5",
+  "version": "0.46.6",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "bin": {
@@ -20,7 +20,7 @@
   },
   "dependencies": {
     "@l2beat/backend-tools": "^0.5.1",
-    "@l2beat/discovery-types": "^0.8.0",
+    "@l2beat/discovery-types": "^0.8.1",
     "@solidity-parser/parser": "^0.18.0",
     "chalk": "^4.1.2",
     "deep-diff": "^1.0.2",

packages/discovery/src/discovery/proxies/auto/GnosisSafe.ts

@@ -28,6 +28,36 @@ async function getMasterCopy(
   }
 }
 
+async function getOwnersCount(
+  provider: DiscoveryProvider,
+  address: EthereumAddress,
+  blockNumber: number,
+): Promise<number | undefined> {
+  const owners = await getCallResult<string[]>(
+    provider,
+    address,
+    'function getOwners() view returns (address[])',
+    [],
+    blockNumber,
+  )
+
+  return owners?.length
+}
+
+async function getThreshold(
+  provider: DiscoveryProvider,
+  address: EthereumAddress,
+  blockNumber: number,
+): Promise<number | undefined> {
+  return await getCallResult<number>(
+    provider,
+    address,
+    'function getThreshold() view returns (uint256)',
+    [],
+    blockNumber,
+  )
+}
+
 export async function detectGnosisSafe(
   provider: DiscoveryProvider,
   address: EthereumAddress,
@@ -41,13 +71,24 @@ export async function detectGnosisSafe(
   const modules = await getModules(provider, address, blockNumber)
   assert(modules, 'Could not find modules for GnosisSafe')
 
+  const ownerCount = await getOwnersCount(provider, address, blockNumber)
+  const threshold = await getThreshold(provider, address, blockNumber)
+  let thresholdString = 'Cannot retrieve threshold'
+  if (ownerCount !== undefined && threshold !== undefined) {
+    thresholdString = `${threshold} of ${ownerCount} (${(
+      (threshold / ownerCount) *
+      100
+    ).toFixed()}%)`
+  }
+
   return {
     implementations: [masterCopy],
     relatives: modules,
     upgradeability: {
       type: 'gnosis safe',
       masterCopy,
       modules,
+      threshold: thresholdString,
     },
   }
 }