[pull] main from microsoft:main #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
#16955) ## Summary of the Pull Request ## References and Relevant Issues Fixes "Align 'Run this profile as Administrator' Settings Description with Microsoft Style Guidelines" #16946 ## Detailed Description of the Pull Request / Additional comments Expanded the contraction "it'll" to "it will" on line 993 of `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` ## Validation Steps Performed N/A ## PR Checklist - [X] Closes #16946 - [ ] Tests added/passed - No tests were added - [ ] Documentation updated - No documentation was updated - [ ] Schema updated (if necessary) - No schema was updated
As discussed in #6176 and #16754. The "CGA" and "IBM 5153" names I'm told are the right ones to use: #16754 (comment) Closes #6176 Closes #16754
This removes `VtApiRoutines` and the VT passthrough mode. Why? While VT passthrough mode has a clear advantage (doesn't corrupt VT sequences) it fails to address other pain points (performance, out-of-sync issues after resize, etc.). Alternative options are available which have less restrictions. Why now? It's spring! Spring cleanup!
The former was introduced when we were still using C++17. We're using C++20 now so it's not needed anymore.
I've found that #16079 was never properly addressed (it still randomly occurred after even after PR #16349), which later led to the issues described in #16769 (nushell flickering due to too many flushes). The crux of the fix is that this brings back the `_noFlushOnEnd` flag that was removed in PR #15991. This is then combined with a change to the cork API: An `uncork` on `VtEngine` now only flushes if `_Flush` got called while it was corked in the first place. `_noFlushOnEnd` prevents us from flushing in between two "unknown" VT sequences (like soft fonts or FTCS) which prevents them from being corrupted. The corking prevents the remaining cases of flushing too often. Long-term, a proper fix would be to pass through VT unmodified. Closes #16769
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )