Update dependencies so yofi builds with the latest Rust #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l4l
reviewed
Aug 30, 2024
FriederHannenheim
force-pushed
the
master
branch
from
ad721ba
to
21869c9
Compare
|
Thanks! |
|
@FriederHannenheim Thanks for this. Seems like you have updated the whole deps in this, which should be alright if the author is cool with it. Ill update the package in nixpkgs soon. |
|
I did #173 earlier but was not showing up for some unforseen reason. It is essentially the same but with just the time crate pulled to latest. |
|
Oh indeed, I wonder how have I missed your PR. In general deps update is fine as long as no new crate duplicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.80.0 introduced a regression that prevents older versions of the Time package from compiling (rust-lang/rust#127343). I noticed this because yofi wouldn't build after a nixos update so I created this PR that updates dependencies and fixes building.
I would like if you could do a patch release so the package can be updated in nixpkgs.