Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separate conda env for each example #29

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use separate conda env for each example #29

merged 1 commit into from
Oct 20, 2023

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Oct 17, 2023

To merge after #28.

This allows us to have separate versions of dependencies for different examples, and pull in non-python dependencies such as dftb.

This also allows to use different versions of Python itself (librascal does not work with Python > 3.10).


📚 Documentation preview 📚: https://software-cookbook--29.org.readthedocs.build/en/29/

@Luthaf Luthaf force-pushed the separate-conda-env branch 4 times, most recently from 66ce295 to 78c3fdb Compare October 19, 2023 17:07
@PicoCentauri PicoCentauri force-pushed the separate-conda-env branch 2 times, most recently from 4975766 to aed86ae Compare October 20, 2023 07:02
Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement. I think the could try to cleanup the enviroment.yml files a bit more. i.e. move general deps to the tox file if possible.

docs/src/lode_linear/images/sphx_glr_lode_tutorial_001.png Outdated Show resolved Hide resolved
examples/lode_linear/environement.yml Outdated Show resolved Hide resolved
examples/lode_linear/environement.yml Outdated Show resolved Hide resolved
@Luthaf Luthaf force-pushed the separate-conda-env branch 2 times, most recently from 40ae7bb to da76975 Compare October 20, 2023 11:00
@Luthaf Luthaf force-pushed the separate-conda-env branch from da76975 to 83a1067 Compare October 20, 2023 11:08
@Luthaf Luthaf requested a review from PicoCentauri October 20, 2023 13:26
@Luthaf Luthaf merged commit 598dd30 into main Oct 20, 2023
2 checks passed
@Luthaf Luthaf deleted the separate-conda-env branch October 20, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants