-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaned up and converted to rascaline the selection example #35
Conversation
Here is the build version of the cookbook in this pull request: documentation.zip, you can view it locally by unzipping |
This is an example of the selection of a diverse subset of structures | ||
from a dataset of candidates (a collection of barium titanate structures) | ||
using SOAP features and FPS and CUR selection. It then also demonstrates | ||
how the same techniques can be used to select the most relevant features. | ||
|
||
It showcases the use of ``rascaline`` to compute descriptors for a | ||
database of atomic structures, and ``scikit-matter`` to compute the | ||
FPS and CUR selections. The structures are visualized using ``chemiscope`` widgets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think unfortunately this nowhere rendered for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put this in the header of the example maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then this is a bit duplicated, no? The problem is that we somehow abusing the structure of the gallery. I think the idea is that several example scripts are within one folder while we always only have one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for sure we are abusing the structure a bit here =). What I meant was to have an empty README, and push the content to the example if it is important
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README is not rendered for any example I thought it was more of a reminder for someone that want to modify the directory to understand what it is.
I do not know for me it is fine both having it empty and putting this in the *py
file or keep it here and not have it rendered.
A part for this for me the PR is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering this more as a reminder for developers - it's true that the notebook format is self-documenting but I like for the README to say something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with michele if is ok for the others I would merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
Now that CI and local kind of work, we can start making the examples nicer and advertise them a bit.