Infrastructure updates #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwa7
reviewed
Mar 26, 2024
jwa7
approved these changes
Mar 26, 2024
Comment on lines
+131
to
+153
| # TODO: Explain | ||
| with open(file) as fd: | ||
| content = fd.read() | ||
|
|
||
| if "Download Conda environment file" in content: | ||
| # do not add the download link twice | ||
| pass | ||
| else: | ||
| lines = content.split("\n") | ||
| with open(file, "w") as fd: | ||
| for line in lines: | ||
| if "sphx-glr-download-jupyter" in line: | ||
| # add the new download link before | ||
| fd.write( | ||
| """ | ||
| .. container:: sphx-glr-download | ||
|
|
||
| :download:`Download Conda environment file: environment.yml <environment.yml>` | ||
| """ | ||
| ) | ||
|
|
||
| fd.write(line) | ||
| fd.write("\n") |
There was a problem hiding this comment.
Seems to work very well. I don't know if like that this is here. I rather would like to put this as an extensions sphinx-gallery directly.
I will explore this.
There was a problem hiding this comment.
Did you find a way to do this? Or should we merge this version for now?
There was a problem hiding this comment.
I have an idea how to do this within the conf.py. But, we can merge this and I change this later!
PicoCentauri
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42
Fix #43