Bugfix: Overlap matrix had extra normalization #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the wrong orthonormalization in rascal for GTO basis.
The code was mixing two conventions for the GTOs.
The overlap matrix was defined using the normalized GTOs, while the rest of the code is using the primitive GTOs (just the r^n times Gaussian part). Now, the coefficients obtained from librascal agree with those from "exact calculations" and those from pyLODE up to a global factor.
The original code was trying to take the extra normalization into account by multiplying the expansion coefficients again with the same normalization factors. Most likely, there was something wrong in the execution of these steps. We are trying to understand this in more detail, but for the time being, the new coefficients agree with the approaches mentioned above and seem to be correct.
Still TODO: