Upload track as ZIP instead of GPX to reduce file size (#64) #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescr
reviewed
Feb 11, 2025
| * @param fileGPX GPX file. | ||
| * @return The created ZIP file or null if an error occurred. | ||
| */ | ||
| public static File zipFile(Context context, long trackId, File fileGPX) { |
There was a problem hiding this comment.
zipGPXFile sounds like a better name for this method.
|
Check if osmapi needs a PR to better suit this purpose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the track upload process by compressing the GPX file into a ZIP before uploading to the OSM server, addressing issue,
Changes:
Benefits:
Dependency:
⚠️ Before merging this PR, PR #501: Improved GPX Sharing: Share as ZIP must be approved and merged.
Let me know if any adjustments are needed! 🚀