client: names in compact output when listing resources #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. Is there a special reason for the square brackets? I would just drop them, so the match can be copy & pasted into |
|
I went with the brackets because they indicate that the name is optional when adding as a match and for consistency to the verbose output. I don't have a strong opinion about either, should the verbose output be changed as well? |
Signed-off-by: Felix Zwettler <[email protected]>
flxzt
force-pushed
the
list-resources-names
branch
from
d2a0acb
to
b17f570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds that resources names are printed in the compact output of the
labgrid-client resourcescommand.For example, instead of:
the output becomes
which makes it easier to differentiate between resources that have the same class.
The alternative would be to enable verbose printing with
labgrid-client -v resources, but that adds a lot of other information and makes is quite hard to pick out the name quickly.At least in my experience the resource name is the only info that I need 95% of the time, so I think it would be beneficial to add it to the default output.
What do you think?