Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agentwrapper: Allow specifying agent prefix #1584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjamin1313
Copy link

Allows client to specify where on the exporter .labgrid_agent_{agent_hash}.py should be copied to. Default is the user homedir.

Description

Checklist

  • Documentation for the feature
  • Tests for the feature
  • PR has been tested
  • Man pages have been regenerated

Allows client to specify where on the exporter .labgrid_agent_{agent_hash}.py should be copied to.
Default is the user homedir.

Signed-off-by: Benjamin B. Frost <[email protected]>
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate a bit more on why you need this? Uploading these files to other directories than the users home directory could mean that they can be modified by a different user and this may provide a security risk.

@benjamin1313
Copy link
Author

Can you elaborate a bit more on why you need this? Uploading these files to other directories than the users home directory could mean that they can be modified by a different user and this may provide a security risk.

We are running the labgrid exporter as a systemd portable service. The homedir for the exporter user is read-only (this is on purpose). We have tmpfs dirs available for the service we use for this purpose. They are local to the portable service, so not available to other users.
With a agent prefix we get more control over where the agent is saved allowing us to place it in a tmpfs dir instead of the homedir.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.0%. Comparing base (f81f479) to head (346180f).
Report is 19 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1584   +/-   ##
======================================
  Coverage    56.0%   56.0%           
======================================
  Files         170     170           
  Lines       13307   13308    +1     
======================================
+ Hits         7458    7459    +1     
  Misses       5849    5849           
Flag Coverage Δ
3.10 56.0% <100.0%> (+<0.1%) ⬆️
3.11 56.0% <100.0%> (+<0.1%) ⬆️
3.12 56.0% <100.0%> (+<0.1%) ⬆️
3.13 56.0% <100.0%> (+<0.1%) ⬆️
3.9 56.0% <100.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants