Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users: adrian: add #67

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adrian-cph
Copy link

No description provided.

@esmil
Copy link
Member

esmil commented Jun 21, 2024

Hi Adrian,

It looks good except for the weird extra whitespace. I can remove that when committing, but your commits seem to be from adrian-cph <[email protected]>. I would have expected something like Adrian Hansen <[email protected]>

You should be able to fix it with

git config --global user.name 'Adrian Hansen'
git config --global user.email '[email protected]'
git rebase -r origin/master --exec 'git commit --amend --no-edit --reset-author'

..and then force push the new version to the same users-adrian-add branch in your github fork to update this pull request.

@adrian-cph
Copy link
Author

Thank you for the input i will fix these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants