Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use unix domain socket to interact with runner #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: use unix domain socket to interact with runner #4

wants to merge 3 commits into from

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Oct 28, 2022 •
edited
Loading

Updating libbaihook to this version will break compatibility with Backend.AI krunner prior to 22.09.5.

@kyujin-cho kyujin-cho self-assigned this Oct 28, 2022
@kyujin-cho kyujin-cho requested a review from achimnol October 28, 2022 07:12
@kyujin-cho kyujin-cho changed the title feat: use unix domain socket to interact with runenr feat: use unix domain socket to interact with runner Oct 28, 2022
@kyujin-cho kyujin-cho mentioned this pull request Oct 28, 2022
Merged
achimnol
achimnol requested changes Nov 2, 2022
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For compatibility, let's first check the existence/file-type of the input_sock and fallback to the prior implementation if it does not exist.

@kyujin-cho kyujin-cho requested a review from achimnol November 2, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol Awaiting requested review from achimnol

Requested changes must be addressed to merge this pull request.

Assignees

@kyujin-cho kyujin-cho

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyujin-cho @achimnol