-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove legacy user creation modal #2755
base: feat/user-list-page
Are you sure you want to change the base?
feat: remove legacy user creation modal #2755
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving this PR to the parent of #2757, and removing the credential view file?
ba3f04c
to
c98cc2a
Compare
1417227
to
2d2084d
Compare
c98cc2a
to
b23ed6a
Compare
2d2084d
to
88112af
Compare
b23ed6a
to
be33acc
Compare
1f06be9
to
42880b8
Compare
be33acc
to
c13fd6b
Compare
Changes:
This PR removes the functionality for adding new users directly from the credential view. Specifically:
newUserDialog
query and related dialog HTML_launchUserAddDialog
and_addUser
methods_validatePassword
,_validatePassword1
,_validatePassword2
_togglePasswordVisibility
methodRationale:
The user creation functionality has likely been moved to a separate component or is being handled differently in the application. This change simplifies the credential view by focusing it on credential management rather than user management.
Impact:
Checklist: