Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change default icon and type, color of CopyButton #2808

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Nov 1, 2024

Changes:
Replaces Lucide React icons with Ant Design icons in the CopyButton component and enhances styling by:

  • Switching from CopyIcon to CopyOutlined and CheckIcon to CheckOutlined
  • Adding default text button type
  • Applying primary theme color to the button
  • Improving props handling by separating button-specific props

Rationale:
Maintains consistency with Ant Design's icon system and styling patterns while reducing external dependencies.

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Nov 1, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:S 10~30 LoC label Nov 1, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Nov 1, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.09% (-0% 🔻)
348/6839
🔴 Branches 4.64% 218/4698
🔴 Functions 2.97% 67/2257
🔴 Lines
4.99% (-0% 🔻)
333/6680

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from d9036e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant