Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression of AgentSummary GQL resolver #3045

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Nov 7, 2024

When using the AgentSummary GQL query in the main branch, the following error occurs.

{
  "data": {
    "agent_summary": null
  },
  "errors": [
    {
      "message": "Agent.batch_load() got an unexpected keyword argument 'scaling_group'",
      "locations": [
        {
          "line": 2,
          "column": 5
        }
      ],
      "path": [
        "agent_summary"
      ]
    }
  ]
}

This PR fixes the above error and additionally resolves several type errors.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

📚 Documentation preview 📚: https://sorna--3045.org.readthedocs.build/en/3045/


📚 Documentation preview 📚: https://sorna-ko--3045.org.readthedocs.build/ko/3045/

@jopemachine jopemachine self-assigned this Nov 7, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC labels Nov 7, 2024
@jopemachine jopemachine added the type:bug Reports about that are not working label Nov 7, 2024
@jopemachine jopemachine added this to the 23.09 milestone Nov 7, 2024
@jopemachine jopemachine marked this pull request as ready for review November 7, 2024 07:27
src/ai/backend/manager/models/gql_models/agent.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/gql_models/agent.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/gql_models/agent.py Outdated Show resolved Hide resolved
changes/3045.fix.md Outdated Show resolved Hide resolved
@jopemachine jopemachine changed the title fix: Wrong AgentSummary GQL implementation fix: Regression of the AgentSummary GQL resolver Nov 12, 2024
@jopemachine jopemachine changed the title fix: Regression of the AgentSummary GQL resolver fix: Regression of AgentSummary GQL resolver Nov 12, 2024
Copy link

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's no problem now.

@HyeockJinKim
Copy link

Ah, ci failed. Could you please check it? @jopemachine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants