Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove labeled triggers for skip:ci #3122

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Nov 20, 2024

CI workflow contains multiple jobs and you are using labels or other criteria to determine whether each job should be skipped.
However, we are using labeled triggers to cope with this, which is causing unnecessary workflow execution and preventing concurrency groups from solving concurrency issues.
So we solve this by removing the labeled trigger from the ci workflow and creating a separate workflow that creates a commit based on the skip:ci label.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@github-actions github-actions bot added the size:M 30~100 LoC label Nov 20, 2024
@Yaminyam Yaminyam added this to the 23.09 milestone Nov 20, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.

.github/workflows/skip-ci.yml Outdated Show resolved Hide resolved
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant