Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependancies #2522

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Bump dependancies #2522

merged 1 commit into from
Oct 11, 2023

Conversation

stefanb
Copy link
Contributor

@stefanb stefanb commented Sep 20, 2023

Bump:

The main motivation is golang.org/x/net which got cleaned up recently in v0.15.0 via golang/net@4a2d37e removing the reference to ancient ubuntu:trusty, which has currently 559 known vulnerabilities, 4 of which are critical, triggering various false positive alerts...

@aldas
Copy link
Contributor

aldas commented Sep 21, 2023

this seems ok

small rant: but I have a remark about that golang/net@4a2d37e this affect only test files. If your tools are reporting these are "important" problems I think problem lies in the security scanning tooling. At the moment it is easy to upgrade deps but in long run this CVE world is getting out of hand as it does only surface level scanning/checking of deps and does not consider at all if vulnerable code is included/used/executed or not, causing ripples up in the dependency graph.

@stefanb
Copy link
Contributor Author

stefanb commented Sep 21, 2023

@aldas Yep, I fully agree! Those are just vendored test files of the upstream project, but some security scanners are still flagging them as an issue. I know it is false positive, but hate having this come up every once in a while.

Can't wait for the next release to finally silence the scanners.

Bump:
* golang.org/x/net v0.12.0 -> v0.15.0
* golang.org/x/crypto v0.11.0 -> v0.13.0
* github.com/stretchr/testify v1.8.1 -> v1.8.4

go mod tidy
@stefanb
Copy link
Contributor Author

stefanb commented Oct 11, 2023

Rebasing after #2527 left only github.com/stretchr/testify v1.8.1 -> v1.8.4 (diff stretchr/testify@v1.8.1...v1.8.4)

@aldas aldas merged commit 89ae0e5 into labstack:master Oct 11, 2023
14 checks passed
@stefanb stefanb deleted the bump-dependancies branch October 11, 2023 05:06
@aldas aldas mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants