Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update golang-jwt to v4.5.1 #2700

Closed
wants to merge 1 commit into from

Conversation

inge4pres
Copy link

@inge4pres inge4pres commented Nov 8, 2024

Fixes #2699

We want to avoid a known vulnerability in golang-jwt library is flagged as a security concern when using echo as a framework in our applications.

Tests are passing locally with the new version.

@cgalibern
Copy link

cgalibern commented Nov 18, 2024

Hi @inge4pres,
Is there a reason why you don't propose github.com/golang-jwt/jwt/v5 ?

Sorry the response is into #2699

@aldas
Copy link
Contributor

aldas commented Nov 18, 2024

Because there will be v6 one day + some CVE and we again need to upgrade that library version. Echo core library tries very hard not to introduce backwards incompatible changes. So in long run removing this dependency is better strategy. We already have https://github.com/labstack/echo-jwt which from first day said is not trying to be stable and not introduce breaking changes.

being stable and not breaking things is one of the most important feature of Go. In comparison to Javascript ecosystem Go is a bliss to maintain older applications. I very much want Echo to honor this tradition as much as we can - but CVEs pop up every other year with JWT.

@inge4pres inge4pres mentioned this pull request Nov 19, 2024
3 tasks
@inge4pres
Copy link
Author

Superseded by #2701

@inge4pres inge4pres closed this Nov 19, 2024
@aldas aldas mentioned this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade golang-jwt to v4
3 participants