Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): add support for fetching user_data info #577

Merged

Conversation

mostaphaRoudsari
Copy link
Member

No description provided.

Copy link
Member

@chriswmackey chriswmackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merged!


assert get_attr_nested(to_, 'user_data.tag') == 'A1'
assert get_attr_nested(to_, 'user_data.__layer__') == 'Default'
assert get_attr_nested(to_, 'user_data.data.name') == 'none-of-your-business'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. A unit test with attitude!

@chriswmackey chriswmackey merged commit fdb6e9e into ladybug-tools:master Aug 3, 2023
8 checks passed
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🎉 This PR is included in version 1.56.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants