Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enterprise repos before adding new repos #291

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

agross
Copy link

@agross agross commented Feb 15, 2025

Closes #290

* Every removal would trigger "apt update" with the remaining (inaccessible) repos, add an extra update_cache: false.
* https://enterprise.proxmox.com/debian/ceph-quincy is configured on a fresh Proxmox 8.x install.
@lae
Copy link
Owner

lae commented Feb 15, 2025

Duplicate of #288, #192, and #96.

This method breaks the primary platform target, Debian. See those PRs for previous discussion on this issue. Installations based on the Proxmox ISO are still outside of the scope of this role, but changes meant for them are okay as long as it doesn't break plain Debian installs.

@agross
Copy link
Author

agross commented Feb 16, 2025

In this case what about removing it before taking other apt-related actions (for ISO installs, potentially with failed_when: false) and after the installation task (for plain Debian installs)?

Failed_when could be dynamically assigned if an ISO install can be detected (Ansible package facts? Would have to check.)

Given the number of PRs related to this your user base seems to include a bunch of people who use the ISO installer, myself included.

@agross
Copy link
Author

agross commented Feb 21, 2025

What do you think about the idea of removing the repos before and after the installation?

  • On Debian, before will be a no-op because they won't exist yet. After installation, the repo added by the installer will be removed.

  • On ISO installs, the before task will remove the already present repo and allow the process to be completed without apt errors. After installation, removal will be a no-op.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add Proxmox repository" fails on a clean install without subscription
2 participants