[FIX] Fix OpenCV automatic Canny threshold

lagadic · Oct 30, 2024 · cc3881e · cc3881e
1 parent 1843fcb
commit cc3881e
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/modules/core/src/image/vpImageFilter_canny.cpp b/modules/core/src/image/vpImageFilter_canny.cpp
@@ -203,6 +203,18 @@ float vpImageFilter::computeCannyThreshold(const cv::Mat &cv_I, const cv::Mat *p
                                            const float &lowerThresholdRatio, const float &upperThresholdRatio,
                                            const vpImageFilter::vpCannyFilteringAndGradientType &filteringType)
 {
+  if ((lowerThresholdRatio <= 0.f) || (lowerThresholdRatio >= 1.f)) {
+    std::stringstream errMsg;
+    errMsg << "Lower ratio (" << lowerThresholdRatio << ") " << (lowerThresholdRatio < 0.f ? "should be greater than 0 !" : "should be lower than 1 !");
+    throw(vpException(vpException::fatalError, errMsg.str()));
+  }
+
+  if ((upperThresholdRatio <= 0.f) || (upperThresholdRatio >= 1.f)) {
+    std::stringstream errMsg;
+    errMsg << "Upper ratio (" << upperThresholdRatio << ") " << (upperThresholdRatio < 0.f ? "should be greater than 0 !" : "should be lower than 1 !");
+    throw(vpException(vpException::fatalError, errMsg.str()));
+  }
+
   double w = cv_I.cols;
   double h = cv_I.rows;
   int bins = 256;