Skip to content

Commit

Permalink
Fix display having wrong override name
Browse files Browse the repository at this point in the history
  • Loading branch information
SamFlt committed Sep 24, 2024
1 parent 4dfd6f3 commit d4ecd40
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions modules/python/bindings/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@ set_source_files_properties(${python_bindings_cpp_src} PROPERTIES GENERATED TRUE

pybind11_add_module(_visp ${python_bindings_cpp_src})




# Place library in build/modules/python/bindings dir so that it doesn't pollute lib dir
# This .so file is not treated the same as the others and we shouldn't link against it when compiling in C++
# when installing the python module, pip will look into this subfolder for .so files to copy into the site-packages
Expand Down
2 changes: 1 addition & 1 deletion modules/python/bindings/include/rbt/feature_tracker.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class TrampolineRBFeatureTracker : public vpRBFeatureTracker
{
pybind11::gil_scoped_acquire gil; // Acquire the GIL while in this scope.
// Try to look up the overridden method on the Python side.
pybind11::function override = pybind11::get_override(this, "computeVVSIter");
pybind11::function override = pybind11::get_override(this, "display");
if (override) { // method is found
// Pybind seems to copy the frames, so we pass the pointers
override(cam, &I, &IRGB, &depth, type);
Expand Down

0 comments on commit d4ecd40

Please sign in to comment.