Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull fixes from python_wrapper branch #1232

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Sep 13, 2023

Fix for some issues:

  • undefined symbols
  • Missing template specializations for vpRGBf in vpImage
  • Some access issues related to the introduction of json in ViSP

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 62.26% and project coverage change: -0.01% ⚠️

Comparison is base (fed5b91) 54.43% compared to head (a15411f) 54.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1232      +/-   ##
==========================================
- Coverage   54.43%   54.42%   -0.01%     
==========================================
  Files         404      404              
  Lines       49843    49848       +5     
==========================================
  Hits        27130    27130              
- Misses      22713    22718       +5     
Files Changed Coverage Δ
modules/core/include/visp3/core/vpColVector.h 78.72% <0.00%> (ø)
...ules/core/include/visp3/core/vpHomogeneousMatrix.h 100.00% <ø> (ø)
modules/core/include/visp3/core/vpPoseVector.h 80.00% <ø> (ø)
modules/core/include/visp3/core/vpRowVector.h 79.31% <ø> (ø)
modules/core/src/math/matrix/vpColVector.cpp 69.32% <0.00%> (-0.83%) ⬇️
modules/core/src/math/matrix/vpRowVector.cpp 65.40% <0.00%> (+0.29%) ⬆️
...nclude/visp3/visual_features/vpFeaturePointPolar.h 0.00% <ø> (ø)
...l_features/src/visual-feature/vpFeatureEllipse.cpp 72.41% <0.00%> (-0.42%) ⬇️
modules/vs/src/vpServoData.cpp 0.00% <0.00%> (ø)
...re/src/math/transformation/vpTranslationVector.cpp 51.46% <20.00%> (+0.29%) ⬆️
... and 7 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit cb394fe into lagadic:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants