Adding wrapper vpServoPololuMaestro class over RappaPololuMaestro sdk #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow position and velocity control using pololu board Move documentation from .cpp to .h
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 54.40% 54.72% +0.31%
==========================================
Files 400 403 +3
Lines 50514 50273 -241
==========================================
+ Hits 27482 27511 +29
+ Misses 23032 22762 -270 ☔ View full report in Codecov by Sentry. |
- RapaPololuMaestro 3rd party that implements RPMSerialInterface is now embedded in 3rdparty/pololu folder and considered as private - Various changes in vpPTUPololuMaestro and vpServoPololuMaestro classes to shadow RPMSerialInterface class - Clean and remove useless code
correcting spelling
Change initial speed value from 0 to 1. Use Adaptive gain for servo example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow position and velocity control using pololu board.