Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cmake timestamp and git csv retrieval to avoid useless rebuild #1260

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Improve cmake timestamp and git csv retrieval to avoid useless rebuild #1260

merged 1 commit into from
Oct 22, 2023

Conversation

fspindle
Copy link
Contributor

  • Before, visp-build-info.tmp was modified after each call to cmake leading to rebuilding vpIoTools.cpp and thus visp_core...
  • Now visp-build-info.tmp is updated only if necessary
  • This commit removes also all specific cmake code when cmake < 2.8.12

@fspindle
Improve cmake timestamp and git csv retrieval to avoid useless rebuild
f44b4b7 
- Before, visp-build-info.tmp was modified after each call to cmake leading
  to rebuilding vpIoTools.cpp and thus visp_core...
- Now visp-build-info.tmp is updated only if necessary
- This commit removes also all specific cmake code when cmake < 2.8.12
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b0ad17) 54.73% compared to head (f44b4b7) 54.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   54.73%   54.72%   -0.02%     
==========================================
  Files         403      403              
  Lines       50276    50276              
==========================================
- Hits        27521    27512       -9     
- Misses      22755    22764       +9

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle fspindle merged commit d58c72a into lagadic:master Oct 22, 2023
57 of 58 checks passed
@fspindle fspindle deleted the feat_cmake_build branch July 3, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fspindle